linux-kernel - Re: [PATCH] HISI LPC: Add Kconfig MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <026e9f13-7201-57a5-a4b3-8c48a89bf134@huawei.com>
Date:   Thu, 19 Apr 2018 14:08:33 +0100
From:   John Garry <john.garry@...wei.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     "xuwei (O)" <xuwei5@...wei.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Simon Horman <horms+renesas@...ge.net.au>,
        gregkh <gregkh@...uxfoundation.org>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Robin Murphy <robin.murphy@....com>,
        Sebastien Bourdelin <sebastien.bourdelin@...oirfairelinux.com>,
        <bogdan.purcareata@....com>, "Tony Lindgren" <tony@...mide.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Olof Johansson <olof@...om.net>,
        Kevin Hilman <khilman@...nel.org>, <tanxiaojun@...wei.com>
Subject: Re: [PATCH] HISI LPC: Add Kconfig MFD_CORE dependency

On 19/04/2018 13:00, Arnd Bergmann wrote:
> On Thu, Apr 19, 2018 at 1:55 PM, John Garry <john.garry@...wei.com> wrote:
>> For ACPI support of the HiSilicon LPC driver we depend
>> on MFD_CORE config.
>>
>> Currently the HiSi LPC Kconfig entry does not define this
>> dependency, so add it.
>>
>> Fixes: e0aa1563f894 ("HISI LPC: Add ACPI support")
>> Reported-and-tested-by: Tan Xiaojun <tanxiaojun@...wei.com>
>> Signed-off-by: John Garry <john.garry@...wei.com>
>
> Can you explain the specific dependency? Normally MFD_CORE gets
> selected by an MFD driver but not other drivers.
>

For each device on the LPC bus we create an MFD.

The reason we do this is that we need to set the resources of the 
derived MFD, as we should not modify the original ACPI device created in 
ACPI scan. Details are in the log for e0aa1563f894.

Shall I update commit message updated with this info? Or were you just 
interested in the motivation for using MFD?

Thanks,
John

>        Arnd
>
> .
>