linux-kernel - Re: [PATCH 9/9] nds32: Fix the allmodconfig build. To make sure CONFIG_CPU_LITTLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a06HEqLg6Vjj41tFXpG_2iMGEw8kKS4X=B7EuW3vYZ+2A@mail.gmail.com>
Date:   Thu, 19 Apr 2018 15:35:19 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Greentime Hu <green.hu@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greentime <greentime@...estech.com>,
        Guenter Roeck <private@...ck-us.net>
Subject: Re: [PATCH 9/9] nds32: Fix the allmodconfig build. To make sure
 CONFIG_CPU_LITTLE_ENDIAN is default y

On Thu, Apr 19, 2018 at 3:18 PM, Greentime Hu <green.hu@...il.com> wrote:
> This way we can build kernel with CONFIG_CPU_LITTLE_ENDIAN=y and allmodconfig
> will be available.
>
> Signed-off-by: Greentime Hu <greentime@...estech.com>
> ---
>  arch/nds32/Kconfig.cpu | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/nds32/Kconfig.cpu b/arch/nds32/Kconfig.cpu
> index ba44cc539da9..b8c8984d1456 100644
> --- a/arch/nds32/Kconfig.cpu
> +++ b/arch/nds32/Kconfig.cpu
> @@ -1,10 +1,11 @@
>  comment "Processor Features"
>
>  config CPU_BIG_ENDIAN
> -       bool "Big endian"
> +       def_bool !CPU_LITTLE_ENDIAN
>
>  config CPU_LITTLE_ENDIAN
> -        def_bool !CPU_BIG_ENDIAN
> +       bool "Little endian"
> +       default y

Can you still build 'allnoconfig' after this? It will default to big-endian now,
and I'm not sure if this works with an nds32le toolchain.

On other architectures, we pass -mlittle-endian/-mbig-endian to the
compiler to force it into whichever mode the kernel is configured for,
but you don't seem to do that (or your gcc can't do it maybe).

     Arnd