linux-kernel - [PATCH v2] HISI LPC: Add Kconfig MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1524147242-220936-1-git-send-email-john.garry@huawei.com>
Date:   Thu, 19 Apr 2018 22:14:02 +0800
From:   John Garry <john.garry@...wei.com>
To:     <xuwei5@...wei.com>
CC:     <arnd@...db.de>, <geert+renesas@...der.be>,
        <horms+renesas@...ge.net.au>, <gregkh@...uxfoundation.org>,
        <paul.gortmaker@...driver.com>, <robin.murphy@....com>,
        <sebastien.bourdelin@...oirfairelinux.com>,
        <bogdan.purcareata@....com>, <tony@...mide.com>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        <helgaas@...nel.org>, <olof@...om.net>, <khilman@...nel.org>,
        <tanxiaojun@...wei.com>, John Garry <john.garry@...wei.com>
Subject: [PATCH v2] HISI LPC: Add Kconfig MFD_CORE dependency

For ACPI support of the HiSilicon LPC driver we depend
on MFD_CORE config.

Currently the HiSi LPC Kconfig entry does not define this
dependency, so add it.

The reason for depending on MFD_CORE in the driver is
that we model the LPC host as an MFD, in that a platform
device will be created for each device on the bus. 

We do this as we need to modify the resources of these
derived platform devices, something which we should not
do to the original devices created in the ACPI scan.
Details in e0aa1563f894 ("HISI LPC: Add ACPI support").

Fixes: e0aa1563f894 ("HISI LPC: Add ACPI support")
Reported-and-tested-by: Tan Xiaojun <tanxiaojun@...wei.com>
Signed-off-by: John Garry <john.garry@...wei.com>
---

v1->v2 change:
- add details of reasong to use MFD to commit message

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index d1c0b60..6dc177b 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -33,6 +33,7 @@ config HISILICON_LPC
 	bool "Support for ISA I/O space on HiSilicon Hip06/7"
 	depends on ARM64 && (ARCH_HISI || COMPILE_TEST)
 	select INDIRECT_PIO
+	select MFD_CORE if ACPI
 	help
 	  Driver to enable I/O access to devices attached to the Low Pin
 	  Count bus on the HiSilicon Hip06/7 SoC.
-- 
1.9.1