linux-kernel - Re: [PATCH V2 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180419142441.GW25429@dragon>
Date:   Thu, 19 Apr 2018 22:24:42 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Anson Huang <Anson.Huang@....com>, mark.rutland@....com,
        devicetree@...r.kernel.org, mturquette@...libre.com,
        linux-clk@...r.kernel.org, linux@...linux.org.uk,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        Linux-imx@....com, kernel@...gutronix.de, fabio.estevam@....com,
        shengjiu.wang@....com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V2 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz
 clock source

On Thu, Apr 19, 2018 at 10:02:37PM +0800, Shawn Guo wrote:
> On Wed, Apr 18, 2018 at 08:17:35PM -0700, Stephen Boyd wrote:
> > Quoting Shawn Guo (2018-04-17 07:22:05)
> > > On Mon, Mar 19, 2018 at 10:30:45AM +0800, Anson Huang wrote:
> > > > On i.MX6SX SabreAuto board, there is external 24MHz clock
> > > > source for analog clock2, add this clock source to clock tree.
> > > > 
> > > > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > > > ---
> > > > changes since V1:
> > > >       remove unnecessary clocks container.
> > > 
> > > I understand this is suggested by Fabio, but I'm afraid that it's not
> > > going to work with imx_obtain_fixed_clock() call, which is coded to
> > > look for clocks under /clocks node.
> > > 
> > 
> > Should patch #1 be dropped from clk tree?
> 
> No.  Patch #1 is good.

Sorry, Stephen.  I just had a closer look at the driver code, and I
think it can be done in a better way.  So please drop patch #1 for now.

Shawn