linux-kernel - Re: [PATCH v2] prctl: fix compat handling for prctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrUmFfoWE55Nrkiq5cuvPw5oPFJKOg04ky-dJsDVsdSmbg@mail.gmail.com>
Date:   Wed, 18 Apr 2018 19:25:27 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Li Bin <huawei.libin@...wei.com>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Lutomirski <luto@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Hanjun Guo <guohanjun@...wei.com>
Subject: Re: [PATCH v2] prctl: fix compat handling for prctl

> On Apr 18, 2018, at 9:06 PM, Li Bin <huawei.libin@...wei.com> wrote:
>
> The member auxv in prctl_mm_map structure which be shared with
> userspace is pointer type, but the kernel supporting COMPAT didn't
> handle it. This patch fix the compat handling for prctl syscall.

I would propose an alternative fix: change the type to u64. As far as
I know, this thing is only used by CRIU, and CRIU doesn’t work (AFAIK)
on native 32-bit anyway.   Do you know of some reason that this
wouldn't work?