linux-kernel - Re: [PATCH] arm64: msm8916: fix gic_irq_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Apr 2018 16:49:21 +0200
From:   Thierry Escande <thierry.escande@...aro.org>
To:     srinivas.kandagatla@...aro.org, andy.gross@...aro.org,
        linux-arm-msm@...r.kernel.org
Cc:     david.brown@...aro.org, robh+dt@...nel.org,
        linux-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: msm8916: fix gic_irq_domain_translate warnings

On 18/04/2018 18:34, srinivas.kandagatla@...aro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> Remove the usage of IRQ_TYPE_NONE to fix loud warnings from
> patch (83a86fbb5b56b "irqchip/gic: Loudly complain about
> the use of IRQ_TYPE_NONE").
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>   arch/arm64/boot/dts/qcom/msm8916.dtsi | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index cfbd72186762..5d66a575c7e1 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi

Reviewed-by: Thierry Escande <thierry.escande@...aro.org>

Also successfully tested on dragonboard 410c so:
Tested-by: Thierry Escande <thierry.escande@...aro.org>

> @@ -180,7 +180,7 @@
>   
>   	pmu {
>   		compatible = "arm,cortex-a53-pmu";
> -		interrupts = <GIC_PPI 7 GIC_CPU_MASK_SIMPLE(4)>;
> +		interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4)| IRQ_TYPE_LEVEL_HIGH)>;
>   	};
>   
>   	thermal-zones {
> @@ -513,7 +513,7 @@
>   		blsp_i2c2: i2c@...6000 {
>   			compatible = "qcom,i2c-qup-v2.2.1";
>   			reg = <0x078b6000 0x500>;
> -			interrupts = <GIC_SPI 96 0>;
> +			interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>   			clocks = <&gcc GCC_BLSP1_AHB_CLK>,
>   				 <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>;
>   			clock-names = "iface", "core";
> @@ -528,7 +528,7 @@
>   		blsp_i2c4: i2c@...8000 {
>   			compatible = "qcom,i2c-qup-v2.2.1";
>   			reg = <0x078b8000 0x500>;
> -			interrupts = <GIC_SPI 98 0>;
> +			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
>   			clocks = <&gcc GCC_BLSP1_AHB_CLK>,
>   				 <&gcc GCC_BLSP1_QUP4_I2C_APPS_CLK>;
>   			clock-names = "iface", "core";
> @@ -543,7 +543,7 @@
>   		blsp_i2c6: i2c@...a000 {
>   			compatible = "qcom,i2c-qup-v2.2.1";
>   			reg = <0x078ba000 0x500>;
> -			interrupts = <GIC_SPI 100 0>;
> +			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
>   			clocks = <&gcc GCC_BLSP1_AHB_CLK>,
>   				 <&gcc GCC_BLSP1_QUP6_I2C_APPS_CLK>;
>   			clock-names = "iface", "core";
> @@ -575,7 +575,7 @@
>   					"mi2s-bit-clk3";
>   			#sound-dai-cells = <1>;
>   
> -			interrupts = <0 160 0>;
> +			interrupts = <0 160 IRQ_TYPE_LEVEL_HIGH>;
>   			interrupt-names = "lpass-irq-lpaif";
>   			reg = <0x07708000 0x10000>;
>   			reg-names = "lpass-lpaif";
> @@ -595,7 +595,7 @@
>   			reg = <0x07824900 0x11c>, <0x07824000 0x800>;
>   			reg-names = "hc_mem", "core_mem";
>   
> -			interrupts = <0 123 0>, <0 138 0>;
> +			interrupts = <0 123 IRQ_TYPE_LEVEL_HIGH>, <0 138 IRQ_TYPE_LEVEL_HIGH>;
>   			interrupt-names = "hc_irq", "pwr_irq";
>   			clocks = <&gcc GCC_SDCC1_APPS_CLK>,
>   				 <&gcc GCC_SDCC1_AHB_CLK>,
> @@ -612,7 +612,7 @@
>   			reg = <0x07864900 0x11c>, <0x07864000 0x800>;
>   			reg-names = "hc_mem", "core_mem";
>   
> -			interrupts = <0 125 0>, <0 221 0>;
> +			interrupts = <0 125 IRQ_TYPE_LEVEL_HIGH>, <0 221 IRQ_TYPE_LEVEL_HIGH>;
>   			interrupt-names = "hc_irq", "pwr_irq";
>   			clocks = <&gcc GCC_SDCC2_APPS_CLK>,
>   				 <&gcc GCC_SDCC2_AHB_CLK>,
> @@ -819,7 +819,7 @@
>   			iommu-ctx@...0 {
>   				compatible = "qcom,msm-iommu-v1-ns";
>   				reg = <0x2000 0x1000>;
> -				interrupts = <GIC_SPI 242 0>;
> +				interrupts = <GIC_SPI 242 IRQ_TYPE_LEVEL_HIGH>;
>   			};
>   		};
>   
> @@ -864,7 +864,7 @@
>   				      "bus_clk",
>   				      "vsync_clk";
>   
> -			interrupts = <0 72 0>;
> +			interrupts = <0 72 IRQ_TYPE_LEVEL_HIGH>;
>   
>   			interrupt-controller;
>   			#interrupt-cells = <1>;
>