linux-kernel - Re: [PATCH net] vmxnet3: fix incorrect dereference when rxvlan is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180419.135955.1394035686984705882.davem@davemloft.net>
Date:   Thu, 19 Apr 2018 13:59:55 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     doshir@...are.com
Cc:     netdev@...r.kernel.org, pv-drivers@...are.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] vmxnet3: fix incorrect dereference when rxvlan is
 disabled

From: Ronak Doshi <doshir@...are.com>
Date: Wed, 18 Apr 2018 12:48:04 -0700

> vmxnet3_get_hdr_len() is used to calculate the header length which in
> turn is used to calculate the gso_size for skb. When rxvlan offload is
> disabled, vlan tag is present in the header and the function references
> ip header from sizeof(ethhdr) and leads to incorrect pointer reference.
> 
> This patch fixes this issue by taking sizeof(vlan_ethhdr) into account
> if vlan tag is present and correctly references the ip hdr.
> 
> Signed-off-by: Ronak Doshi <doshir@...are.com>
> Acked-by: Guolin Yang <gyang@...are.com>
> Acked-by: Louis Luo <llouis@...are.com>

Applied and queued up for -stable, thanks.

Please provide an appropriate Fixes: tag next time.