linux-kernel - Re: [9/9] nds32: Fix the allmodconfig build. To make sure CONFIG_CPU_LITTLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180419183840.GA500@roeck-us.net>
Date:   Thu, 19 Apr 2018 11:38:40 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Greentime Hu <green.hu@...il.com>
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de,
        greentime@...estech.com, private@...ck-us.net
Subject: Re: [9/9] nds32: Fix the allmodconfig build. To make sure
 CONFIG_CPU_LITTLE_ENDIAN is default y

On Thu, Apr 19, 2018 at 09:18:15PM +0800, Greentime Hu wrote:
> This way we can build kernel with CONFIG_CPU_LITTLE_ENDIAN=y and allmodconfig
> will be available.
> 
> Signed-off-by: Greentime Hu <greentime@...estech.com>

As Arnd suspected, this causes allnoconfig to fail.
The failure is due to endianness mismatches in vdso code.

Not sure if that is really an improvement.

Guenter

> ---
>  arch/nds32/Kconfig.cpu | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/nds32/Kconfig.cpu b/arch/nds32/Kconfig.cpu
> index ba44cc539da9..b8c8984d1456 100644
> --- a/arch/nds32/Kconfig.cpu
> +++ b/arch/nds32/Kconfig.cpu
> @@ -1,10 +1,11 @@
>  comment "Processor Features"
>  
>  config CPU_BIG_ENDIAN
> -	bool "Big endian"
> +	def_bool !CPU_LITTLE_ENDIAN
>  
>  config CPU_LITTLE_ENDIAN
> -        def_bool !CPU_BIG_ENDIAN
> +	bool "Little endian"
> +	default y
>  
>  config HWZOL
>  	bool "hardware zero overhead loop support"