linux-kernel - Re: [PATCH] regulator: ab8500: tidy ab8500_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180420081246.zos5mblrna2bsj3l@dell>
Date:   Fri, 20 Apr 2018 09:12:46 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] regulator: ab8500: tidy ab8500_regulator_get_mode()

On Thu, 19 Apr 2018, Dan Carpenter wrote:

> The indenting here is confusing.
> 
> Also we don't check "ret".  That isn't likely to cause a runtime issue
> because if it fails here fails then we'd probably return -EINVAL at the
> end anyway.  But it does introduce a static checker warning since "val"
> is only inititialized on the success path.
> 
>     drivers/regulator/ab8500.c:429 ab8500_regulator_get_mode()
>     error: uninitialized symbol 'val'.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog