linux-kernel - Re: [PATCH] mfd: tps65911-comparator: Fix an off by one bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180420085938.ymf2jc46dswylxh4@mwanda>
Date:   Fri, 20 Apr 2018 11:59:39 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Lee Jones <lee.jones@...aro.org>,
        Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mfd: tps65911-comparator: Fix an off by one bug

On Thu, Apr 19, 2018 at 04:46:34PM +0300, Dan Carpenter wrote:
> The tps_comparators[] array is used in two places.  We only access the
> COMP1 (1) and COMP2 (2) elements.  Unfortunately, we're accessing the
> wrong elements and also one element beyond the end of the array.  There
> was supposed to be a zero element at the start of the array which is
> isn't accessed but makes the math work out nicely.
> 
> Fixes: 6851ad3ab346 ("TPS65911: Comparator: Add comparator driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> I can't actually compile this code...

I assumed that I couldn't compile this code because it was non-x86 or
something but actually it's just really out of date.  We broke it in
2012 when we removed the ->write() function pointer.

commit 3f7e82759c692df473675ed06fb90b20f1f225c3
Author: Rhyland Klein <rklein@...dia.com>
Date:   Tue May 8 11:42:38 2012 -0700

    mfd: Commonize tps65910 regmap access through header

regards,
dan carpenter