[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <VI1PR04MB14558BCFB82A06C92F7AA0CA8BB40@VI1PR04MB1455.eurprd04.prod.outlook.com>
Date: Fri, 20 Apr 2018 09:35:54 +0000
From: Peter Chen <peter.chen@....com>
To: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH resend] usb: chipidea: Don't select EXTCON
> >
> > Sorry to reply late, are you really care 2KB code side? Since many
> > users use EXTCON to handle vbus and id, it is hard just delete it. I
> > could accept patch for your specific platforms, like:
> >
> > + select EXTCON if !ARCH_XXXX
>
> The patch doesn't remove extcon support from chipidea driver.
> I just want to not select EXTCON unconditionally, but let the users choose. If the
> users need extcon, they could enable EXTCON themselves
>
> I just searched all the dts in arch/arm/boot/dts and arch/arm64/boot/dts only the four
> dts give extcon phandle to chipidea host, other users don't make use of it:
>
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
>
> arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>
> arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts
>
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
>
I see, but I do not want to break msm platforms. You may try to create Glue driver Kconfig
entry for chipidea like dwc3, and let msm depends on EXTCON.
Peter
Powered by blists - more mailing lists