[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87d0yui33r.fsf@kamboji.qca.qualcomm.com>
Date: Fri, 20 Apr 2018 13:28:24 +0300
From: Kalle Valo <kvalo@...eaurora.org>
To: Andres Rodriguez <andresx7@...il.com>
Cc: linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
mcgrof@...nel.org, alexdeucher@...il.com,
ckoenig.leichtzumerken@...il.com, arend.vanspriel@...adcom.com
Subject: Re: [PATCH 5/9] firmware: add functions to load firmware without warnings v4
Andres Rodriguez <andresx7@...il.com> writes:
> Currently the firmware loader only exposes one silent path for querying
> optional firmware, and that is firmware_request_direct(). This function
> also disables the fallback path, which might not always be the
> desired behaviour. [0]
>
> This patch introduces variations of firmware_request() and
> firmware_request_nowait() that enable the caller to disable the
> undesired warning messages. This is equivalent to adding FW_OPT_NO_WARN,
> to the old behaviour.
>
> v2: add header prototype, use updated opt_flags
> v3: split debug message to separate patch
> added _nowait variant
> added documentation
> v4: fix kernel-doc style
>
> [0]: https://git.kernel.org/linus/c0cc00f250e1
>
> Signed-off-by: Andres Rodriguez <andresx7@...il.com>
> ---
> .../driver-api/firmware/request_firmware.rst | 13 ++++--
> drivers/base/firmware_loader/main.c | 52 ++++++++++++++++++++--
> include/linux/firmware.h | 6 +++
> 3 files changed, 63 insertions(+), 8 deletions(-)
The changelog should be after the "---" line, this way git-am will
automatically discard it.
--
Kalle Valo
Powered by blists - more mailing lists