linux-kernel - Re: [PATCH 2/3] xen netback: add fault injection facility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d205346f-d77a-8e5c-753d-c05623a6c55a@amazon.com>
Date:   Fri, 20 Apr 2018 15:02:35 +0200
From:   <staskins@...zon.com>
To:     Juergen Gross <jgross@...e.com>
CC:     <jakub.kicinski@...ronome.com>, <hpa@...or.com>,
        <mcroce@...hat.com>, <tglx@...utronix.de>, <ggarcia@...a.uab.cat>,
        <daniel@...earbox.net>, <x86@...nel.org>, <mingo@...hat.com>,
        <xen-devel@...ts.xenproject.org>, <axboe@...nel.dk>,
        <konrad.wilk@...cle.com>, <amir.jer.levy@...el.com>,
        <paul.durrant@...rix.com>, <stefanha@...hat.com>,
        <dsa@...ulusnetworks.com>, <boris.ostrovsky@...cle.com>,
        <linux-block@...r.kernel.org>, <wei.liu2@...rix.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <davem@...emloft.net>, <dwmw@...zon.co.uk>, <roger.pau@...rix.com>
Subject: Re: [PATCH 2/3] xen netback: add fault injection facility

On 04/20/18 15:00, Juergen Gross wrote:
> On 20/04/18 14:52, staskins@...zon.com wrote:
>> On 04/20/18 13:25, Juergen Gross wrote:
>>> On 20/04/18 12:47, Stanislav Kinsburskii wrote:
>>>> +    for (fi = 0; fi < XENVIF_FI_MAX; fi++) {
>>>> +        vfi->faults[fi] = xen_fi_dir_add(vfi->dir,
>>>> +                xenvif_fi_names[fi]);
>>> How does this work? xenvif_fi_names[] is an empty array and this is the
>>> only reference to it. Who is allocating the memory for that array?
>> Well, it works in the way one adds a var to enum (which is used as a key
>> later) and a corresponding string into the array (which is used as a
>> name for the fault directory in sysfs).
> Then you should size the array via XENVIF_FI_MAX.

Makes sense.
Thanks!

Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B