linux-kernel - Re: [RFC PATCH 2/2] HISI LPC: Add PNP device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1524230910.21176.474.camel@linux.intel.com>
Date:   Fri, 20 Apr 2018 16:28:30 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     John Garry <john.garry@...wei.com>, rjw@...ysocki.net,
        linux-acpi@...r.kernel.org, lenb@...nel.org,
        mika.westerberg@...ux.intel.com, lorenzo.pieralisi@....com
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de,
        graeme.gregory@...aro.org, helgaas@...nel.org, linuxarm@...wei.com,
        z.liuxinliang@...ilicon.com
Subject: Re: [RFC PATCH 2/2] HISI LPC: Add PNP device support

On Fri, 2018-04-20 at 14:09 +0100, John Garry wrote:
> On 20/04/2018 13:50, Andy Shevchenko wrote:
> > On Fri, 2018-04-20 at 18:07 +0800, John Garry wrote:

> > > +			if (res->flags | IORESOURCE_IO)
> > 
> > What does this mean?
> 
> Here we check the resource flag for each resource for this PNP device
> - 
> for IO resources we must translate the resource value from the bus 
> address to the logical PIO address.

Please, re-read your code again.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy