[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20180420164625.b2d91c9f9738492eeaa8e3e7@gmail.com>
Date: Fri, 20 Apr 2018 16:46:25 +0200
From: Ahmed Abdelsalam <amsalam20@...il.com>
To: David Lebrun <dav.lebrun@...il.com>
Cc: davem@...emloft.net, dlebrun@...gle.com, kuznet@....inr.ac.ru,
yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net] ipv6: sr: fix NULL pointer dereference in
seg6_do_srh_encap()- v4 pkts
On Fri, 20 Apr 2018 15:38:08 +0100
David Lebrun <dav.lebrun@...il.com> wrote:
> On 04/20/2018 02:58 PM, Ahmed Abdelsalam wrote:
> > In case of seg6 in encap mode, seg6_do_srh_encap() calls set_tun_src()
> > in order to set the src addr of outer IPv6 header.
> >
> > The net_device is required for set_tun_src(). However calling ip6_dst_idev()
> > on dst_entry in case of IPv4 traffic results on the following bug.
> >
> > Using just dst->dev should fix this BUG.
> >
>
> Good catch, thanks for spotting this. If you actually tested your fix
> with IPv4 and IPv6 traffic, you should mention it in the commit message.
> Your current formulation suggests that you just guessed a fix without
> testing.
>
Yes, I did two tests for both IPv4 and IPv6.
Sorry for this Language Bug.
> >
> > Fixes: 8936ef7604c11 ipv6: sr: fix NULL pointer dereference when setting encap source address
> > Signed-off-by: Ahmed Abdelsalam<amsalam20@...il.com>
>
> Acked-by: David Lebrun <dlebrun@...gle.com>
--
Ahmed Abdelsalam <amsalam20@...il.com>
Powered by blists - more mailing lists