linux-kernel - Re: [regression v4.17-rc0] Re: FORTIFY_SOURCE breaks ARM compilation in -next -- was Re: ARM compile failure in Re: linux-next: Tree for Apr 4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+6D3PiVc9SR4+31ZGDC2r5uWJOw8Sn3cDhXdNqBGH+hQ@mail.gmail.com>
Date:   Fri, 20 Apr 2018 08:05:17 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Daniel Micay <danielmicay@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        Thorsten Leemhuis <regressions@...mhuis.info>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        pali.rohar@...il.com, sre@...nel.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-omap@...r.kernel.org, Kevin Hilman <khilman@...nel.org>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        ivo.g.dimitrov.75@...il.com,
        Patrik Bachan <patrikbachan@...il.com>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Mickuláš Qwertz <abcloriens@...il.com>,
        Clayton Craft <clayton@...ftyguy.net>,
        Martijn Braam <martijn@...xit.nl>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Filip Matijević <filip.matijevic.pz@...il.com>,
        Jinbum Park <jinb.park7@...il.com>,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [regression v4.17-rc0] Re: FORTIFY_SOURCE breaks ARM compilation
 in -next -- was Re: ARM compile failure in Re: linux-next: Tree for Apr 4

On Fri, Apr 20, 2018 at 12:34 AM, Pavel Machek <pavel@....cz> wrote:
> On Sun 2018-04-15 11:00:06, Kees Cook wrote:
>> On Sun, Apr 15, 2018 at 10:39 AM, Pavel Machek <pavel@....cz> wrote:
>> > Hi!
>> >
>> >> Thanks.
>> >>
>> >> Ok, let me try to bisect it. Compile-problem should be easy...
>> >>
>> >> Hmm. And as it is compile-problem in single file, it should even be
>> >> reasonably fast. I did not realize how easy it would be:
>> >>
>> >> #!/bin/bash
>> >> set -e
>> >> cp config.ok .config
>> >> yes '' | ARCH=arm make lib/string.o
>> >>
>> >> And the winner is:
>> >>
>> >> ee333554fed55555a986a90bb097ac7f9d6f05bf is the first bad commit
>> >> commit ee333554fed55555a986a90bb097ac7f9d6f05bf
>> >> Author: Jinbum Park <jinb.park7@...il.com>
>> >> Date:   Tue Mar 6 01:39:24 2018 +0100
>> > ...
>> >
>> >>     Acked-by: Kees Cook <keescook@...omium.org>
>> >>     Signed-off-by: Jinbum Park <jinb.park7@...il.com>
>> >>     Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
>> >
>> > So I bisect a problem in -next, and patch is merged to Linus,
>> > _anyway_, breaking compilation there? Neither Jinbum nor Russell even
>> > bother to comment.
>>
>> Hi! Sorry I lost this email in my inbox. It seems this is specific to
>> a particular subset of arm architectures? (My local builds of arm all
>> succeed, for example. Can you send your failing config?) I'll take a
>> closer look on Monday if Daniel doesn't beat me to it.
>
> Daniel, Kees: any news?
>
> I'm aware you did not specify which Monday :-).

Hi! Sorry, I got distracted. So the .config you sent me builds fine
with my cross compiler. I suspect this is something specific to ELDK's
compiler. I can try some other compiler versions. What version of gcc
is failing?

-Kees

-- 
Kees Cook
Pixel Security