linux-kernel - Re: [PATCH 1/2] x86/microcode/intel: Save microcode patch unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180420155950.GA9792@araj-mobl1.jf.intel.com>
Date:   Fri, 20 Apr 2018 08:59:50 -0700
From:   "Raj, Ashok" <ashok.raj@...el.com>
To:     Borislav Petkov <bp@...e.de>
Cc:     Vitezslav Samel <vitezslav@...el.cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, x86-ml <x86@...nel.org>
Subject: Re: [PATCH 1/2] x86/microcode/intel: Save microcode patch
 unconditionally

On Fri, Apr 20, 2018 at 12:34:28PM +0200, Borislav Petkov wrote:
> save_mc_for_early() was a no-op on !CONFIG_HOTPLUG_CPU but the
> generic_load_microcode() path saves the microcode patches it has found
> into our cache of patches which is used for late loading too. Regardless
> of whether we do CPU hotplug or not.
> 
> So make the saving unconditional so that late loading can find the
> proper patch.
> 
> Reported-by: Vitezslav Samel <vitezslav@...el.cz>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Ashok Raj <ashok.raj@...el.com>

Tested-by: Ashok Raj <ashok.raj@...el.com>

> Cc: <stable@...r.kernel.org> # if it has backported d8c3b52c00a05036e0a6b315b4b17921a7b67997
> Link: http://lkml.kernel.org/r/20180418081140.GA2439@pc11.op.pod.cz
> ---