linux-kernel - Re: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <858fbd0a-a387-e9f8-5017-1fff9638dd4d@infradead.org>
Date:   Fri, 20 Apr 2018 10:53:06 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mario Limonciello <mario.limonciello@...l.com>,
        dvhart@...radead.org, Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.

On 04/20/18 10:42, Mario Limonciello wrote:
> As reported by Randy Dunlap:
>>> WARNING: unmet direct dependencies detected for DELL_SMBIOS
>>>   Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y]
>>> 	&& (DCDBAS [=m] ||
>>> DCDBAS [=m]=n) && (ACPI_WMI [=n] || ACPI_WMI [=n]=n)
>>>   Selected by [y]:
>>>   - DELL_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y]
>>> && DMI [=y]
>>> && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] ||
>>> 	ACPI_VIDEO [=n]=n)
>>> && (RFKILL [=n] || RFKILL [=n]=n) && SERIO_I8042 [=y]
>>>
> 
> Right now it's possible to set dell laptop to compile in but this
> causes dell-smbios to compile in which breaks if dcdbas is a module.
> 
> Dell laptop shouldn't select dell-smbios anymore, but depend on it.
> 
> Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve dependency error on DCDBAS)

meta-comment: the SHA-1 ID should be the first 12 characters of the commit ID
according to Documentation/process/submitting-patches.rst.


> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Mario Limonciello <mario.limonciello@...l.com>

Tested-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/platform/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 39d06dd..bc309c5 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -154,7 +154,7 @@ config DELL_LAPTOP
>  	depends on ACPI_VIDEO || ACPI_VIDEO = n
>  	depends on RFKILL || RFKILL = n
>  	depends on SERIO_I8042
> -	select DELL_SMBIOS
> +	depends on DELL_SMBIOS
>  	select POWER_SUPPLY
>  	select LEDS_CLASS
>  	select NEW_LEDS
> 


-- 
~Randy