linux-kernel - Re: [PATCH v4] tracing: remove igrab() iput() call from uprobes.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45E2FF15-D82B-43AA-ADF4-0B440A87D12C@fb.com>
Date:   Fri, 20 Apr 2018 18:49:40 +0000
From:   Song Liu <songliubraving@...com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>,
        Ingo Molnar <mingo@...hat.com>,
        Howard McLauchlan <hmclauchlan@...com>,
        Josef Bacik <jbacik@...com>,
        Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
        Miklos Szeredi <miklos@...redi.hu>
Subject: Re: [PATCH v4] tracing: remove igrab() iput() call from uprobes.c



> On Apr 20, 2018, at 11:40 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> On Fri, 20 Apr 2018 18:36:38 +0000
> Song Liu <songliubraving@...com> wrote:
> 
>>> On Apr 20, 2018, at 11:29 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
>>> 
>>> On Fri, 20 Apr 2018 11:08:47 -0700
>>> Song Liu <songliubraving@...com> wrote:
>>> 
>>>> For uprobes.c sisde, igrab() is not necessary. So we removed it and  
>>> 
>>> You don't need to send another patch, but what is the above sentence
>>> suppose to say?
>>> 
>>> -- Steve
>>> 
>> 
>> Sorry for the typo. I meant "For uprobes.c side". Or "it is not necessary
>> to call igrab() in uprobe_register(), as the caller is required to keep
>> the inode reference. 
>> 
> 
> I'll update it to:
> 
> "For uprobes.c, it is not necessary to call igrab() in
> uprobe_register(), as the caller is required to keep the inode
> reference. The igrab() is removed and comments on this requirement is
> added to uprobe_register()."
> 
> -- Steve


Looks good!

Thanks,
Song