linux-kernel - Re: [PATCH 1/2] drm/exynos: fimd: Add support for S5PV210 FIMD variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Apr 2018 18:55:17 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
Cc:     Inki Dae <inki.dae@...sung.com>, jy0922.shim@...sung.com,
        Seung Woo Kim <sw0312.kim@...sung.com>,
        kyungmin.park@...sung.com, airlied@...ux.ie, kgene@...nel.org,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, linux-kernel@...r.kernel.org,
        Tomasz Figa <tomasz.figa@...il.com>
Subject: Re: [PATCH 1/2] drm/exynos: fimd: Add support for S5PV210 FIMD variant

On Fri, Apr 20, 2018 at 6:32 PM, Paweł Chmiel
<pawel.mikolaj.chmiel@...il.com> wrote:
> From: Tomasz Figa <tomasz.figa@...il.com>
>
> This patch adds support for FIMD variant found on S5PV210 SoC.
> Except CLKSEL bit availability, it is identical to Exynos4210.
>
> Tested-by: Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
> Signed-off-by: Tomasz Figa <tomasz.figa@...il.com>

You need to add your Signed-off-by here as well. It is necessary every
time you touch a patch (and sending it is also a "touch" action).

Best regards,
Krzysztof

> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index d42ae2bc3e56..01b1570d0c3a 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -121,6 +121,12 @@ static struct fimd_driver_data s3c64xx_fimd_driver_data = {
>         .has_limited_fmt = 1,
>  };
>
> +static struct fimd_driver_data s5pv210_fimd_driver_data = {
> +       .timing_base = 0x0,
> +       .has_shadowcon = 1,
> +       .has_clksel = 1,
> +};
> +
>  static struct fimd_driver_data exynos3_fimd_driver_data = {
>         .timing_base = 0x20000,
>         .lcdblk_offset = 0x210,
> @@ -193,6 +199,8 @@ struct fimd_context {
>  static const struct of_device_id fimd_driver_dt_match[] = {
>         { .compatible = "samsung,s3c6400-fimd",
>           .data = &s3c64xx_fimd_driver_data },
> +       { .compatible = "samsung,s5pv210-fimd",
> +         .data = &s5pv210_fimd_driver_data },
>         { .compatible = "samsung,exynos3250-fimd",
>           .data = &exynos3_fimd_driver_data },
>         { .compatible = "samsung,exynos4210-fimd",
> --
> 2.7.4
>