lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <tip-78b562fbfa2cf0a9fcb23c3154756b690f4905c1@git.kernel.org> Date: Sat, 21 Apr 2018 00:48:58 -0700 From: tip-bot for Jiri Olsa <tipbot@...or.com> To: linux-tip-commits@...r.kernel.org Cc: mingo@...nel.org, eranian@...gle.com, namhyung@...nel.org, acme@...hat.com, jolsa@...nel.org, linux-kernel@...r.kernel.org, andi@...stfloor.org, hpa@...or.com, peterz@...radead.org, alexander.shishkin@...ux.intel.com, tglx@...utronix.de Subject: [tip:perf/urgent] perf: Return proper values for user stack errors Commit-ID: 78b562fbfa2cf0a9fcb23c3154756b690f4905c1 Gitweb: https://git.kernel.org/tip/78b562fbfa2cf0a9fcb23c3154756b690f4905c1 Author: Jiri Olsa <jolsa@...nel.org> AuthorDate: Sun, 15 Apr 2018 11:23:50 +0200 Committer: Arnaldo Carvalho de Melo <acme@...hat.com> CommitDate: Tue, 17 Apr 2018 09:47:39 -0300 perf: Return proper values for user stack errors Return immediately when we find issue in the user stack checks. The error value could get overwritten by following check for PERF_SAMPLE_REGS_INTR. Signed-off-by: Jiri Olsa <jolsa@...nel.org> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com> Cc: Andi Kleen <andi@...stfloor.org> Cc: H. Peter Anvin <hpa@...or.com> Cc: Namhyung Kim <namhyung@...nel.org> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Stephane Eranian <eranian@...gle.com> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: syzkaller-bugs@...glegroups.com Cc: x86@...nel.org Fixes: 60e2364e60e8 ("perf: Add ability to sample machine state on interrupt") Link: http://lkml.kernel.org/r/20180415092352.12403-1-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com> --- kernel/events/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 1bae80aaabfb..67612ce359ad 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -10209,9 +10209,9 @@ static int perf_copy_attr(struct perf_event_attr __user *uattr, * __u16 sample size limit. */ if (attr->sample_stack_user >= USHRT_MAX) - ret = -EINVAL; + return -EINVAL; else if (!IS_ALIGNED(attr->sample_stack_user, sizeof(u64))) - ret = -EINVAL; + return -EINVAL; } if (!attr->sample_max_stack)
Powered by blists - more mailing lists