lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <6932041.eDZ2n7hNsz@avalon> Date: Sat, 21 Apr 2018 11:47:45 +0300 From: Laurent Pinchart <laurent.pinchart@...asonboard.com> To: Sean Paul <seanpaul@...omium.org> Cc: dri-devel@...ts.freedesktop.org, Rob Herring <robh@...nel.org>, Maxime Ripard <maxime.ripard@...e-electrons.com>, Archit Taneja <architt@...eaurora.org>, Andrzej Hajda <a.hajda@...sung.com>, stable@...r.kernel.org, David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] drm/bridge: vga-dac: Fix edid memory leak Hi Sean, Thank you for the patch. On Friday, 20 April 2018 21:59:59 EEST Sean Paul wrote: > edid should be freed once it's finished being used. > > Fixes: 56fe8b6f4991 ("drm/bridge: Add RGB to VGA bridge support") > Cc: Rob Herring <robh@...nel.org> > Cc: Sean Paul <seanpaul@...omium.org> > Cc: Maxime Ripard <maxime.ripard@...e-electrons.com> > Cc: Archit Taneja <architt@...eaurora.org> > Cc: Andrzej Hajda <a.hajda@...sung.com> > Cc: Laurent Pinchart <Laurent.pinchart@...asonboard.com> > Cc: <stable@...r.kernel.org> # v4.9+ > Signed-off-by: Sean Paul <seanpaul@...omium.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com> > --- > drivers/gpu/drm/bridge/dumb-vga-dac.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c > b/drivers/gpu/drm/bridge/dumb-vga-dac.c index 498d5948d1a8..9837c8d69e69 > 100644 > --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c > +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c > @@ -56,7 +56,9 @@ static int dumb_vga_get_modes(struct drm_connector > *connector) } > > drm_mode_connector_update_edid_property(connector, edid); > - return drm_add_edid_modes(connector, edid); > + ret = drm_add_edid_modes(connector, edid); > + kfree(edid); > + return ret; > > fallback: > /* -- Regards, Laurent Pinchart
Powered by blists - more mailing lists