[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180421090449.GA8194@kroah.com>
Date: Sat, 21 Apr 2018 11:04:49 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Tom Hromatka <tom.hromatka@...cle.com>
Cc: davem@...emloft.net, sparclinux@...r.kernel.org, arnd@...db.de,
linux-kernel@...r.kernel.org, shuah@...nel.org,
linux-kselftest@...r.kernel.org, allen.pais@...cle.com,
khalid.aziz@...cle.com, shannon.nelson@...cle.com,
anthony.yznaga@...cle.com
Subject: Re: [PATCH v4 1/2] char: sparc64: Add privileged ADI driver
On Fri, Apr 20, 2018 at 02:52:20PM -0600, Tom Hromatka wrote:
> --- /dev/null
> +++ b/drivers/char/adi.c
> @@ -0,0 +1,240 @@
> +// SPDX-License-Identifier: GPL-2.0
Good, but:
> +MODULE_LICENSE("GPL");
That's the wrong line :(
Read include/linux/module.h for the correct string to put here for a
GPL version 2 only module.
thanks,
greg k-h
Powered by blists - more mailing lists