linux-kernel - Re: [alsa-devel] [PATCH 1/4] ALSA: usb: stream: refactor audio interface parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB=otbQK3P5W-GCxncu-J2mCVuQYZuEBmOW=QJOKVF7RNUPGNQ@mail.gmail.com>
Date:   Mon, 23 Apr 2018 22:48:49 +0300
From:   Ruslan Bilovol <ruslan.bilovol@...il.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Jorge <jorge.sanjuan@...ethink.co.uk>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [alsa-devel] [PATCH 1/4] ALSA: usb: stream: refactor audio
 interface parsing

On Thu, Apr 19, 2018 at 12:55 PM, Takashi Iwai <tiwai@...e.de> wrote:
> On Sat, 14 Apr 2018 00:24:23 +0200,
> Ruslan Bilovol wrote:
>>
>> Offload snd_usb_parse_audio_interface() function which
>> became quite long after adding UAC3 spec support.
>>
>> Move class-specific parts to separate functions
>> which now produce audioformat structure that is
>> ready to be fed to snd_usb_add_audio_stream().
>>
>> This also broke Blue Microphones workaround (which
>> relies on audioformat decoded from previous altsetting)
>> into two parts: prepare quirk flag analyzing previous
>> altsetting then use it with current altsetting.
>>
>> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@...il.com>
>
> Could you try to split this patch to two parts: one is a simple
> refactoring to move the code to snd_usb_get_audioformat_uac12(), and
> another to add snd_usb_get_audioformat_uac3().
>
> In this way, we can see a problem more clearly if it's in the
> refactoring part.
>

Sure, will do in in next patchset

Thanks,
Ruslan