linux-kernel - Re: [PATCH] Always report a writeback error once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180423215325.4jek2nr7lqy4y532@alap3.anarazel.de>
Date:   Mon, 23 Apr 2018 14:53:25 -0700
From:   Andres Freund <andres@...razel.de>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-fsdevel@...r.kernel.org, Jeff Layton <jlayton@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Always report a writeback error once

On 2018-04-23 14:51:50 -0700, Matthew Wilcox wrote:
> How does this look?
> 
> @@ -111,27 +111,22 @@ EXPORT_SYMBOL(errseq_set);
>   * errseq_sample() - Grab current errseq_t value.
>   * @eseq: Pointer to errseq_t to be sampled.
>   *
> - * This function allows callers to sample an errseq_t value, marking it as
> - * "seen" if required.
> + * This function allows callers to initialise their errseq_t variable.
> + * If the error has been "seen", new callers will not see an old error.
> + * If there is an unseen error in @eseq, the caller of this function will
> + * see it the next time it checks for an error.
>   *
> + * Context: Any context.
>   * Return: The current errseq value.
>   */
>  errseq_t errseq_sample(errseq_t *eseq)

LGTM.