linux-kernel - Re: [PATCH 4.9 37/95] ext4: add validity checks for bitmap block numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180423060352.GA8194@thunk.org>
Date:   Mon, 23 Apr 2018 02:03:52 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Ben Hutchings <ben@...adent.org.uk>
Cc:     stable@...r.kernel.org, Wen Xu <wen.xu@...ech.edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4.9 37/95] ext4: add validity checks for bitmap block
 numbers

On Sun, Apr 22, 2018 at 10:54:23PM +0100, Ben Hutchings wrote:
> >  	offset = blk - group_first_block;
> > -	if (!ext4_test_bit(EXT4_B2C(sbi, offset), bh->b_data))
> > +	if (offset < 0 || EXT4_B2C(sbi, offset) >= sb->s_blocksize ||
> > +	    !ext4_test_bit(EXT4_B2C(sbi, offset), bh->b_data))
> 
> Isn't sb->s_blocksize a count of bytes?  If so, doesn't that mean that
> we should be comparing with sb->s_blocksize * 8?

Yes, nice catch, Ben!  Can we temporarily drop this patch from the
stable queue until I can get a fix in?

In practice this shouldn't be a problem because of the default ext4
layout with flex_bg.  But we should definitely get this fixed before
we let this flow into the stable kernel.

       	    	      	  	 - Ted