linux-kernel - Re: [PATCH v2] phy: core: Allow phy_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8edb158-9286-6877-ce6e-36a421571d8c@ti.com>
Date:   Mon, 23 Apr 2018 12:12:31 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Manu Gautam <mgautam@...eaurora.org>
CC:     <linux-arm-msm@...r.kernel.org>,
        "open list:GENERIC PHY FRAMEWORK" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] phy: core: Allow phy_pm_runtime_xxx API calls with
 NULL phy



On Tuesday 20 March 2018 11:31 AM, Manu Gautam wrote:
> phy_init() and phy_exit() calls, and phy_power_on() and
> phy_power_off() already accept NULL as valid PHY reference
> and act as NOP. Extend same concept to phy runtime_pm APIs
> to keep drivers (e.g. dwc3) code simple while dealing with
> optional PHYs.
> 
> Signed-off-by: Manu Gautam <mgautam@...eaurora.org>

merged, thanks!

-Kishon

> ---
> Changes for v2:
>  - Fixed compilation warning
> 
>  drivers/phy/phy-core.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
> index 3c31ce5..1fda576 100644
> --- a/drivers/phy/phy-core.c
> +++ b/drivers/phy/phy-core.c
> @@ -153,6 +153,9 @@ int phy_pm_runtime_get(struct phy *phy)
>  {
>  	int ret;
>  
> +	if (!phy)
> +		return 0;
> +
>  	if (!pm_runtime_enabled(&phy->dev))
>  		return -ENOTSUPP;
>  
> @@ -168,6 +171,9 @@ int phy_pm_runtime_get_sync(struct phy *phy)
>  {
>  	int ret;
>  
> +	if (!phy)
> +		return 0;
> +
>  	if (!pm_runtime_enabled(&phy->dev))
>  		return -ENOTSUPP;
>  
> @@ -181,6 +187,9 @@ int phy_pm_runtime_get_sync(struct phy *phy)
>  
>  int phy_pm_runtime_put(struct phy *phy)
>  {
> +	if (!phy)
> +		return 0;
> +
>  	if (!pm_runtime_enabled(&phy->dev))
>  		return -ENOTSUPP;
>  
> @@ -190,6 +199,9 @@ int phy_pm_runtime_put(struct phy *phy)
>  
>  int phy_pm_runtime_put_sync(struct phy *phy)
>  {
> +	if (!phy)
> +		return 0;
> +
>  	if (!pm_runtime_enabled(&phy->dev))
>  		return -ENOTSUPP;
>  
> @@ -199,6 +211,9 @@ int phy_pm_runtime_put_sync(struct phy *phy)
>  
>  void phy_pm_runtime_allow(struct phy *phy)
>  {
> +	if (!phy)
> +		return;
> +
>  	if (!pm_runtime_enabled(&phy->dev))
>  		return;
>  
> @@ -208,6 +223,9 @@ void phy_pm_runtime_allow(struct phy *phy)
>  
>  void phy_pm_runtime_forbid(struct phy *phy)
>  {
> +	if (!phy)
> +		return;
> +
>  	if (!pm_runtime_enabled(&phy->dev))
>  		return;
>  
>