linux-kernel - Re: [PATCH] microblaze: Fix simpleImage format generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Apr 2018 10:53:14 +0200
From:   Michal Simek <monstr@...str.eu>
To:     Michal Simek <michal.simek@...inx.com>,
        linux-kernel@...r.kernel.org
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] microblaze: Fix simpleImage format generation

On 10.4.2018 16:00, Michal Simek wrote:
> simpleImage generation was broken for some time. This patch is fixing
> steps how simpleImage.*.ub file is generated. Steps are objdump of
> vmlinux and create .ub.
> Also make sure that there is striped elf version with .strip suffix.
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> 
>  arch/microblaze/boot/Makefile | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/microblaze/boot/Makefile b/arch/microblaze/boot/Makefile
> index fd46385a4c97..600e5a198bd2 100644
> --- a/arch/microblaze/boot/Makefile
> +++ b/arch/microblaze/boot/Makefile
> @@ -22,17 +22,19 @@ $(obj)/linux.bin.gz: $(obj)/linux.bin FORCE
>  quiet_cmd_cp = CP      $< $@$2
>  	cmd_cp = cat $< >$@$2 || (rm -f $@ && echo false)
>  
> -quiet_cmd_strip = STRIP   $@
> +quiet_cmd_strip = STRIP   $< $@$2
>  	cmd_strip = $(STRIP) -K microblaze_start -K _end -K __log_buf \
> -				-K _fdt_start vmlinux -o $@
> +				-K _fdt_start $< -o $@$2
>  
>  UIMAGE_LOADADDR = $(CONFIG_KERNEL_BASE_ADDR)
> +UIMAGE_IN = $@
> +UIMAGE_OUT = $@.ub
>  
>  $(obj)/simpleImage.%: vmlinux FORCE
>  	$(call if_changed,cp,.unstrip)
>  	$(call if_changed,objcopy)
>  	$(call if_changed,uimage)
> -	$(call if_changed,strip)
> -	@echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
> +	$(call if_changed,strip,.strip)
> +	@echo 'Kernel: $(UIMAGE_OUT) is ready' ' (#'`cat .version`')'
>  
>  clean-files += simpleImage.*.unstrip linux.bin.ub
> 

Applied.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)