linux-kernel - Re: [PATCH] serial: 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af71a628-d9c8-bfbd-5772-8fced7c51b6b@huawei.com>
Date:   Mon, 23 Apr 2018 10:22:40 +0100
From:   John Garry <john.garry@...wei.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <jslaby@...e.com>, <joel@....id.au>, <p.zabel@...gutronix.de>,
        <arnd@...db.de>, <fcooper@...com>,
        <sergei.shtylyov@...entembedded.com>,
        <yamada.masahiro@...ionext.com>, <khoroshilov@...ras.ru>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <andriy.shevchenko@...ux.intel.com>, <linuxarm@...wei.com>
Subject: Re: [PATCH] serial: 8250_of: Add IO space support

On 23/04/2018 09:14, Greg KH wrote:
> On Thu, Apr 19, 2018 at 11:37:48PM +0800, John Garry wrote:
>> Currently the 8250_of driver only supports MEM IO type
>> accesses.
>>
>> Some development boards (Huawei D03, specifically) require
>> IO space access for 8250-compatible OF driver support, so
>> add it.
>>
>> The modification is quite simple: just set the port iotype
>> and associated flags depending on the device address
>> resource type.
>>
>> Signed-off-by: John Garry <john.garry@...wei.com>
>
> This no longer applies to my tree due to a patch that was sent before
> yours that conflicts in the same area.  Can you rebase it against my
> tty-testing branch and resend?
>

Hi Greg,

OK, I'll do that. I will also make this small improvement to this patch:

+	if ((resource.flags & IORESOURCE_TYPE_BITS) == IORESOURCE_IO) {
+		port->iotype = UPIO_PORT;

	|
	V

+	if (resource_type(&resource) == IORESOURCE_IO) {
+		port->iotype = UPIO_PORT;

All the best,
John

> thanks,
>
> greg k-h
>
> .
>