linux-kernel - Re: [PATCH] m68k: Remove read_persistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMz4kuLQ2a8FxVB+OuQ2oS2efBuDn5SC-hW5JU4ZMhqowPs57A@mail.gmail.com>
Date:   Mon, 23 Apr 2018 18:31:32 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Mark Brown <broonie@...nel.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k: Remove read_persistent_clock()

Hi Geert,

On 23 April 2018 at 17:07, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> Hi Baolin,
>
> On Mon, Apr 23, 2018 at 4:08 AM, Baolin Wang <baolin.wang@...aro.org> wrote:
>> On 20 April 2018 at 23:22, Arnd Bergmann <arnd@...db.de> wrote:
>>> On Thu, Apr 19, 2018 at 8:22 AM, Baolin Wang <baolin.wang@...aro.org> wrote:
>>>> The read_persistent_clock() uses a timespec, which is not year 2038 safe
>>>> on 32bit systems. Moreover on m68k architecture, we have implemented generic
>>>> RTC drivers that can be used to compensate the system suspend time. So
>>>> we can remove the obsolete read_persistent_clock().
>>>>
>>>> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
>>>
>>> I'm not sure about this one: it's still possible to turn off
>>> CONFIG_RTC_DRV_GENERIC
>>> on M68KCLASSIC, and in that case we still need a read_persistent_clock64()
>>> implementation. Or we use your patch but make CONFIG_RTC_DRV_GENERIC
>>> mandatory.
>>
>> OK. Thanks for fixing the issue with your patch.
>
> Can I consider that an Acked-by?

I will add one reviewed-by tag in Arnd's new patch.

-- 
Baolin.wang
Best Regards