linux-kernel - Re: [PATCH v3 2/2] tracing: remove igrab() iput() call from uprobes.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7D7229C8-C85F-4BE0-BBFC-4184858C311D@fb.com>
Date:   Mon, 23 Apr 2018 11:23:44 +0000
From:   Song Liu <songliubraving@...com>
To:     Miklos Szeredi <miklos@...redi.hu>
CC:     LKML <linux-kernel@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        "Howard McLauchlan" <hmclauchlan@...com>,
        Josef Bacik <jbacik@...com>,
        "Srikar Dronamraju" <srikar@...ux.vnet.ibm.com>
Subject: Re: [PATCH v3 2/2] tracing: remove igrab() iput() call from uprobes.c



> On Apr 23, 2018, at 3:03 AM, Miklos Szeredi <miklos@...redi.hu> wrote:
> 
> On Fri, Apr 20, 2018 at 6:56 PM, Song Liu <songliubraving@...com> wrote:
>> Caller of uprobe_register is required to keep the inode and containing
>> mount point referenced.
>> 
>> Cc: Steven Rostedt <rostedt@...dmis.org>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Howard McLauchlan <hmclauchlan@...com>
>> Cc: Josef Bacik <jbacik@...com>
>> Cc: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
>> Cc: Miklos Szeredi <miklos@...redi.hu>
>> Signed-off-by: Song Liu <songliubraving@...com>
>> ---
>> kernel/events/uprobes.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>> 
>> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
>> index ce6848e..20486bb 100644
>> --- a/kernel/events/uprobes.c
>> +++ b/kernel/events/uprobes.c
>> @@ -491,7 +491,6 @@ static struct uprobe *alloc_uprobe(struct inode *inode, loff_t offset)
>>        if (!uprobe)
>>                return NULL;
>> 
>> -       uprobe->inode = igrab(inode);
> 
> Where has the assignment gone?
> 
> Testing your changes would not hurt...
> 
> Thanks,
> Miklos

Oops.. I tested the trace_uprobe to uprobe part of it, but didn't test
the uprobe itself. (Tested) fix coming soon.

Song