linux-kernel - Re: [PATCH v2 10/75] staging: ks7010: Remove unused 'struct hostif_mib_get_confirm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Apr 2018 14:13:28 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Quytelda Kahja <quytelda@...alin.org>
Cc:     wsa@...-dreams.de, driverdev-devel@...uxdriverproject.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 10/75] staging: ks7010: Remove unused 'struct
 hostif_mib_get_confirm_t'.

On Fri, Mar 30, 2018 at 11:07:50PM -0700, Quytelda Kahja wrote:
> 'struct hostif_mib_get_confirm_t' is not used in this driver. Remove
> 'struct hostif_mib_get_confirm_t'.
> 
> Signed-off-by: Quytelda Kahja <quytelda@...alin.org>
> ---
>  drivers/staging/ks7010/ks_hostif.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
> index aedc832bc04c..e6d6c51ccc43 100644
> --- a/drivers/staging/ks7010/ks_hostif.h
> +++ b/drivers/staging/ks7010/ks_hostif.h
> @@ -151,16 +151,10 @@ struct hostif_mib_value {
>  	u8 body[0];
>  } __packed;
>  
> -struct hostif_mib_get_confirm_t {
> -	struct hostif_hdr header;
> -	__le32 mib_status;
>  #define MIB_SUCCESS    0
>  #define MIB_INVALID    1
>  #define MIB_READ_ONLY  2
>  #define MIB_WRITE_ONLY 3

You should have also removed these #defines as they are not used
anywhere either.

thanks,

greg k-h