linux-kernel - Re: [PATCH v2 75/75] staging: ks7010: Replace memcpy() with ether_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180423122017.GA30910@kroah.com>
Date:   Mon, 23 Apr 2018 14:20:17 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Quytelda Kahja <quytelda@...alin.org>
Cc:     wsa@...-dreams.de, driverdev-devel@...uxdriverproject.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 75/75] staging: ks7010: Replace memcpy() with
 ether_addr_copy().

On Fri, Mar 30, 2018 at 11:08:55PM -0700, Quytelda Kahja wrote:
> ether_addr_copy() is the function for copying a hardware address,
> so replace the manual memcpy() operation with ether_addr_copy().
> 
> Signed-off-by: Quytelda Kahja <quytelda@...alin.org>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index b5a2ba702dec..a461dd568d28 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -522,7 +522,7 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
>  	case DOT11_MAC_ADDRESS:
>  		/* MAC address */
>  		hostif_sme_enqueue(priv, SME_GET_MAC_ADDRESS);
> -		memcpy(dev->dev_addr, priv->rxp, ETH_ALEN);
> +		ether_addr_copy(dev->dev_addr, priv->rxp);
>  		priv->mac_address_valid = true;
>  		netdev_info(dev, "MAC ADDRESS = %pM\n", dev->dev_addr);
>  		break;
> -- 
> 2.16.3

Not all of these patches applied.  Can you please rebase and resend the
remaining ones?

thanks,

greg k-h