linux-kernel - Re: [PATCH] staging: mt7621-eth: fix line over 80 char issue in mtk_set_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 23 Apr 2018 15:25:32 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jefferson Capovilla <jefcap@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: mt7621-eth: fix line over 80 char issue in
 mtk_set_link_ksettings()

On Tue, Apr 03, 2018 at 10:30:50PM -0300, Jefferson Capovilla wrote:
> Fix 'line over 80 characters' issue found by checkpatch.pl script in
> mtk_set_link_ksettings().
> 
> Signed-off-by: Jefferson Capovilla <jefcap@...il.com>
> ---
>  drivers/staging/mt7621-eth/ethtool.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/mt7621-eth/ethtool.c b/drivers/staging/mt7621-eth/ethtool.c
> index 38ba0c0..e9f4092 100644
> --- a/drivers/staging/mt7621-eth/ethtool.c
> +++ b/drivers/staging/mt7621-eth/ethtool.c
> @@ -52,7 +52,8 @@ static int mtk_set_link_ksettings(struct net_device *dev,
>  			mac->phy_dev = mac->hw->phy->phy[cmd->base.phy_address];
>  			mac->phy_flags = MTK_PHY_FLAG_PORT;
>  		} else if (mac->hw->mii_bus) {
> -			mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus, cmd->base.phy_address);
> +			mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus,
> +						       cmd->base.phy_address);
>  			if (!mac->phy_dev)
>  				return -ENODEV;
>  			mac->phy_flags = MTK_PHY_FLAG_ATTACH;
> @@ -62,7 +63,6 @@ static int mtk_set_link_ksettings(struct net_device *dev,
>  	}
>  
>  	return phy_ethtool_ksettings_set(mac->phy_dev, cmd);
> -

You did this too :(

Don't lie in a changelog text, please fix up and resend.

greg k-h