linux-kernel - Re: [PATCH v4 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdwtOS_B978JOXqWRnj611jMJyN7BxFr+qu+Ojdf07i2Q@mail.gmail.com>
Date:   Mon, 23 Apr 2018 16:43:41 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Matthew Garrett <mjg59@...f.ucam.org>,
        Pali Rohár <pali.rohar@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Mario Limonciello <mario.limonciello@...l.com>,
        Takashi Iwai <tiwai@...e.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>
Subject: Re: [PATCH v4 2/3] platform/x86: dell-*: Add interface for switchable
 graphics status query

On Fri, Apr 20, 2018 at 12:44 PM, Kai-Heng Feng
<kai.heng.feng@...onical.com> wrote:
> On some Dell platforms, there's a BIOS option "Enable Switchable
> Graphics". This information is useful if we want to do different things
> based on this value, e.g. disable unused audio controller that comes
> with the discrete graphics.

>  int dell_micmute_led_set(int on);
> +bool dell_switchable_gfx_is_enabled(void);

I would rather preserve existing API, i.e.
 - prototype int func(void), where return either state or negative error code.
 - naming: dell_switchable_gfx_get()

-- 
With Best Regards,
Andy Shevchenko