linux-kernel - Re: Experiencing freezes with kernel 4.16.3 on a desktop with E5500 CPU (bisect included)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180423140052.GO4129@hirez.programming.kicks-ass.net>
Date:   Mon, 23 Apr 2018 16:00:52 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Diego Viola <diego.viola@...il.com>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de,
        len.brown@...el.com, rui.zhang@...el.com,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: Experiencing freezes with kernel 4.16.3 on a desktop with E5500
 CPU (bisect included)

On Mon, Apr 23, 2018 at 02:38:47PM +0200, Peter Zijlstra wrote:
> @@ -834,8 +857,12 @@ static int clocksource_unbind(struct clocksource *cs)
>  		if (curr_clocksource == cs)
>  			return -EBUSY;
>  	}
> +
> +	clocksource_watchdog_lock(&flags);
>  	clocksource_dequeue_watchdog(cs);
>  	list_del_init(&cs->list);
> +	clocksource_watchdog_lock(&flags);

It works a lot better when this is _unlock();

> +
>  	return 0;
>  }
>  

With that, and intel_idle.c modified to always issue the "halts in
idle" thing, my IVB comes up in hpet mode. Let me dig up a Core2 era
machine and see if that works too.