linux-kernel - Re: [PATCH 3/9] perf stat: Keep the / modifier separator in fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180423141629.GB30324@kernel.org>
Date:   Mon, 23 Apr 2018 11:16:29 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 3/9] perf stat: Keep the / modifier separator in fallback

Em Mon, Apr 23, 2018 at 11:08:17AM +0200, Jiri Olsa escreveu:
> The perf stat fallback for EACCES error sets exclude_kernel
> for event and repeats the open. In addition, it also changes
> the name of the event to reflect that change by adding the
> 'u' modifier.
> 
> But it does not take into account the '/' separator, so the
> event name can end up mangled, like:
> (note the '/:' characters)
> 
>   $ perf stat -e cpu/cpu-cycles/ kill
>   ...
>              386,832      cpu/cpu-cycles/:u
> 
> Adding the code to check on the '/' separatos and set
> following event name:
> 
>   $ perf stat -e cpu/cpu-cycles/ kill
>   ...
>              388,548      cpu/cpu-cycles/u

Thanks, tested, reproduced and applied to perf/urgent

- Arnaldo