linux-kernel - Re: Experiencing freezes with kernel 4.16.3 on a desktop with E5500 CPU (bisect included)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180423164425.GS4129@hirez.programming.kicks-ass.net>
Date:   Mon, 23 Apr 2018 18:44:25 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Diego Viola <diego.viola@...il.com>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de,
        len.brown@...el.com, rui.zhang@...el.com,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: Experiencing freezes with kernel 4.16.3 on a desktop with E5500
 CPU (bisect included)

On Mon, Apr 23, 2018 at 05:58:01PM +0200, Peter Zijlstra wrote:
> Thomas, we could not find the de-rate stuff, but the above can be
> simplified; what happens is:
> 
> 	cs->flags |= UNSTABLE;
> 	schedule_work(&watchdog_work)
> 	  kthread_run(clocksource_watchdog_kthread)

Also, Thomas, do you remember why we spawn a short running kthread from
a work ? Can't we simply run the whole thing from the worker thread?

> 	    __clocksource_watchdog_kthread()
> 	      if (cs->flags & UNSTABLE)
> 	        __clocksource_change_rating()
> 	   clocksource_select()
>