linux-kernel - Re: [PATCH 1/2] iio: adc128s052: allow driver to be matched using ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180424182330.000061a5@huawei.com>
Date:   Tue, 24 Apr 2018 18:23:30 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Javier Arteaga <javier@...tex.com>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Dan O'Donovan <dan@...tex.com>, <linux-iio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] iio: adc128s052: allow driver to be matched using
 ACPI

On Sat, 21 Apr 2018 21:41:57 +0100
Javier Arteaga <javier@...tex.com> wrote:

> Hi Jonathan,
> 
> On Sat, Apr 21, 2018 at 04:54:41PM +0100, Jonathan Cameron wrote:
> > I don't really see the connection between the change in here
> > and what the description says...  
> 
> I think you're right, we didn't make our intent clear here.
> 
> > If you are probing from ACPI then there is no need to ensure
> > a valid of table is supplied (even if we aren't building with OF)
> > which is what I think this patch is trying to do...  
> 
> The patch enables ACPI _DSD to reuse existing DT "compatible" strings,
> as described in Documentation/acpi/enumeration.txt, even without OF.
> This kind of patch has some precedent, like for example:
> 
>     01427fe7c4b9 ("Input: adxl34x - make it enumerable in ACPI environment")
> 
> To clarify, for the UP2 board we don't actually need this patch as we
> have an ACPI _HID - just thought it would might be an improvement for
> others.
> 
> I'll improve the description and perhaps reorder this patch last for v2.
> Or I can send separately if you prefer.
> 
> Thanks for your review!
Unless we know of ACPI firmwares out there that are doing this, drop the
patch for now.  I don't want to see a flood of these based on a 'you can
do it that' way argument.

Jonathan

> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html