linux-kernel - Re: [PATCH v2] spi/bcm63xx-hspi: Enable the clock before calling clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180424173253.GF22073@sirena.org.uk>
Date:   Tue, 24 Apr 2018 18:32:53 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Stefan Potyra <Stefan.Potyra@...ktrobit.com>
Cc:     Florian Fainelli <florian.fainelli@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com, linux-spi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Jonas Gorski <jonas.gorski@...il.com>,
        ldv-project@...uxtesting.org, sil2review@...ts.osadl.org
Subject: Re: [PATCH v2] spi/bcm63xx-hspi: Enable the clock before calling
 clk_get_rate().

On Tue, Apr 24, 2018 at 06:16:05PM +0200, Stefan Potyra wrote:

> +	ret = clk_prepare_enable(clk);
> +	if (ret)
> +		return ret;
> +
>  	rate = clk_get_rate(clk);
>  	if (!rate) {
>  		struct clk *pll_clk = devm_clk_get(dev, "pll");
> @@ -364,10 +368,6 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
>  			return -EINVAL;
>  	}
>  
> -	ret = clk_prepare_enable(clk);
> -	if (ret)
> -		return ret;
> -

We can return an error after the clock was enabled, this will leake the
clock if that happens.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)