linux-kernel - Re: [PATCH] net: nfp: fix nfp_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180424110921.24c3699b@cakuba.netronome.com>
Date:   Tue, 24 Apr 2018 11:09:21 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Simon Horman <simon.horman@...ronome.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Dirk van der Merwe <dirk.vandermerwe@...ronome.com>,
        Pablo Cascón <pablo.cascon@...ronome.com>,
        oss-drivers@...ronome.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: nfp: fix nfp_net_tx()'s return type

On Tue, 24 Apr 2018 15:17:07 +0200, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
> 
> Fix this by returning 'netdev_tx_t' in this driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>