linux-kernel - Re: [PATCH] do not call trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180424145056.7c29ea18@gandalf.local.home>
Date:   Tue, 24 Apr 2018 14:50:56 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Wei Wang <wvw@...gle.com>
Cc:     gregkh@...uxfoundation.org, wei.vince.wang@...il.com,
        Ingo Molnar <mingo@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Crt Mori <cmo@...exis.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] do not call trace_printk on non-debug build

On Tue, 24 Apr 2018 11:08:10 -0700
Wei Wang <wvw@...gle.com> wrote:

> From: Wei Wang <wvw@...gle.com>
> 
> trace_printk will cause trace_printk_init_buffers executed in kernel
> start, which will increase memory and also show bad warnings in
> production kernel.
> 

NAK!

Where is trace_printk() being used to trigger this?

trace_printk() is to be added while debugging, but one should not need
to enable DEBUG to use it. But it should be removed when finished.

-- Steve

> Signed-off-by: Wei Wang <wvw@...gle.com>