linux-kernel - Re: [PATCH 2/7] ARM: dts: sun8i: h3: Split out common board design for ALL-H3-CC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180424193754.jsuucbq57onhxhqe@flea>
Date:   Tue, 24 Apr 2018 21:37:54 +0200
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Neil Armstrong <narmstrong@...libre.com>
Subject: Re: [PATCH 2/7] ARM: dts: sun8i: h3: Split out common board design
 for ALL-H3-CC

On Tue, Apr 24, 2018 at 08:17:11PM +0800, Chen-Yu Tsai wrote:
> On Tue, Apr 24, 2018 at 8:13 PM, Maxime Ripard
> <maxime.ripard@...tlin.com> wrote:
> > On Tue, Apr 24, 2018 at 07:34:19PM +0800, Chen-Yu Tsai wrote:
> >> The Libre Computer Project ALL-H3-CC has three models, all using the
> >> same board design, but with different pin compatible SoCs and amount of
> >> DRAM.
> >>
> >> Currently only the H3 1GB DRAM variant is supported. To support the two
> >> other variants, first split the original device tree into a common board
> >> design part and an SoC specific part.
> >>
> >> The SoC part only defines which SoC is used and model name, and includes
> >> the SoC specific dtsi file and the common design dtsi file.
> >>
> >> Also fix up the SPDX identifier line to use the correct comment style,
> >> and place it on the first line.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@...e.org>
> >> ---
> >>  .../boot/dts/sun8i-h3-libretech-all-h3-cc.dts | 213 +-----------------
> >>  ....dts => sunxi-hx-libretech-all-h3-cc.dtsi} |  11 +-
> >
> > I think I prefer the name of Neil's DTSI better, and since pretty much
> > the same patches (a couple of hours) before, we'll merge them (while
> > merging the rest of your patches, obviously).
> >
> > Does that work for you?
> 
> I would like for the regulator voltage fix to be merged before the split.
> This will make it trivial to back port, instead of having to reverse the
> split, and maybe failing.

Yes, I was just talking about replacing your two redundant patches,
but keeping the order you have.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com