linux-kernel - Re: [PATCH] do not call trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180424164837.3f1bcd20@gandalf.local.home>
Date:   Tue, 24 Apr 2018 16:48:37 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Wei Wang <wvw@...gle.com>
Cc:     gregkh@...uxfoundation.org, Wei Wang <wei.vince.wang@...il.com>,
        Ingo Molnar <mingo@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Crt Mori <cmo@...exis.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] do not call trace_printk on non-debug build

On Tue, 24 Apr 2018 16:45:05 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 24 Apr 2018 20:39:27 +0000
> Wei Wang <wvw@...gle.com> wrote:
> 
> > The config is not something new and it is controlling pr_debug and
> > pr_devel, so might not be too annoying, IMHO. But I agree this is not a
> > problem from us but from abusers.  
> 
> And is the reason I never use pr_debug() and pr_devel().
> 

Which reminds me, I need to replace pr_debug() to pr_info() for this
line:

  pr_debug("syscall %s metadata not mapped, disabling ftrace event\n",

In trace_syscalls.c (I didn't add that), as a different commit that
changed syscall names for x86 caused all syscall tracepoints to
disappear. And if this was pr_info() and not pr_debug() the one that
made the change would have noticed his change had impact someplace else.

-- Steve