linux-kernel - Re: [PATCH 2/2] ata: ahci: mvebu: override ahci_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180424062246.GB14537@kroah.com>
Date:   Tue, 24 Apr 2018 08:22:46 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     xswang@...vell.com
Cc:     linux-ide@...r.kernel.org, tj@...nel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        oferh@...vell.com, dingwei@...vell.com, xigu@...vell.com,
        nadavh@...vell.com, Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 2/2] ata: ahci: mvebu: override ahci_stop_engine for
 mvebu AHCI

On Tue, Apr 24, 2018 at 12:06:45PM +0800, xswang@...vell.com wrote:
> From: Evan Wang <xswang@...vell.com>
> 
> There is an issue(Errata Ref#226) that the SATA can not be
> detected via SATA Port-MultiPlayer(PMP) with following
> error log:
>   ata1.15: PMP product ID mismatch
>   ata1.15: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
>   ata1.15: Port Multiplier vendor mismatch '0x1b4b'!='0x0'
>   ata1.15: PMP revalidation failed (errno=-19)
> 
> After debugging, the reason is found that the value Port-x
> FIS-based Switching Control(PxFBS@...0) become wrong.
> According to design, the bits[11:8, 0] of register PxFBS
> are cleared when Port Command and Status (0x18) bit[0]
> changes its value from 1 to 0, i.e. falling edge of Port
> Command and Status bit[0] sends PULSE that resets PxFBS
> bits[11:8; 0].
> So it needs a mvebu SATA WA to save the port PxFBS register
> before PxCMD ST write and restore it afterwards.
> 
> This patch implements the WA in a separate function of
> ahci_mvebu_stop_engine to override ahci_stop_gngine.
> 
> Signed-off-by: Evan Wang <xswang@...vell.com>
> Suggested-by: Ofer Heifetz <oferh@...vell.com>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>
> ---
>  drivers/ata/ahci_mvebu.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>