linux-kernel - [tip:x86/urgent] x86/microcode/intel: Save microcode patch unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-84749d83758af6576552046b215b9b7f37f9556b@git.kernel.org>
Date:   Tue, 24 Apr 2018 00:51:50 -0700
From:   tip-bot for Borislav Petkov <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     vitezslav@...el.cz, linux-kernel@...r.kernel.org, mingo@...nel.org,
        bp@...e.de, hpa@...or.com, ashok.raj@...el.com, tglx@...utronix.de
Subject: [tip:x86/urgent] x86/microcode/intel: Save microcode patch
 unconditionally

Commit-ID:  84749d83758af6576552046b215b9b7f37f9556b
Gitweb:     https://git.kernel.org/tip/84749d83758af6576552046b215b9b7f37f9556b
Author:     Borislav Petkov <bp@...e.de>
AuthorDate: Sat, 21 Apr 2018 10:19:29 +0200
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Tue, 24 Apr 2018 09:48:22 +0200

x86/microcode/intel: Save microcode patch unconditionally

save_mc_for_early() was a no-op on !CONFIG_HOTPLUG_CPU but the
generic_load_microcode() path saves the microcode patches it has found into
the cache of patches which is used for late loading too. Regardless of
whether CPU hotplug is used or not.

Make the saving unconditional so that late loading can find the proper
patch.

Reported-by: Vitezslav Samel <vitezslav@...el.cz>
Signed-off-by: Borislav Petkov <bp@...e.de>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Tested-by: Vitezslav Samel <vitezslav@...el.cz>
Tested-by: Ashok Raj <ashok.raj@...el.com>
Cc: stable@...r.kernel.org
Link: http://lkml.kernel.org/r/20180418081140.GA2439@pc11.op.pod.cz
Link: https://lkml.kernel.org/r/20180421081930.15741-1-bp@alien8.de

---
 arch/x86/kernel/cpu/microcode/intel.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index 32b8e5724f96..1c2cfa0644aa 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -485,7 +485,6 @@ static void show_saved_mc(void)
  */
 static void save_mc_for_early(u8 *mc, unsigned int size)
 {
-#ifdef CONFIG_HOTPLUG_CPU
 	/* Synchronization during CPU hotplug. */
 	static DEFINE_MUTEX(x86_cpu_microcode_mutex);
 
@@ -495,7 +494,6 @@ static void save_mc_for_early(u8 *mc, unsigned int size)
 	show_saved_mc();
 
 	mutex_unlock(&x86_cpu_microcode_mutex);
-#endif
 }
 
 static bool load_builtin_intel_microcode(struct cpio_data *cp)