| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Apr 2018 11:03:40 +0300
From: Ruslan Bilovol <ruslan.bilovol@...il.com>
To: Jorge Sanjuan <jorge.sanjuan@...ethink.co.uk>
Cc: Takashi Iwai <tiwai@...e.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
alsa-devel@...a-project.org,
Michael Drake <michael.drake@...ethink.co.uk>,
linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/4] ALSA: usb-audio: ADC3: Fix channel
mapping conversion for ADC3.
On Fri, Apr 20, 2018 at 8:03 PM, Jorge Sanjuan
<jorge.sanjuan@...ethink.co.uk> wrote:
> From: Michael Drake <michael.drake@...ethink.co.uk>
>
> The channel mapping is defined by bChRelationship, not bChPurpose.
>
> Signed-off-by: Michael Drake <michael.drake@...ethink.co.uk>
> ---
> sound/usb/stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/stream.c b/sound/usb/stream.c
> index 6a8f5843334e..956be9f7c72a 100644
> --- a/sound/usb/stream.c
> +++ b/sound/usb/stream.c
> @@ -349,7 +349,7 @@ snd_pcm_chmap_elem *convert_chmap_v3(struct uac3_cluster_header_descriptor
> * TODO: this conversion is not complete, update it
> * after adding UAC3 values to asound.h
> */
> - switch (is->bChPurpose) {
> + switch (is->bChRelationship) {
Good catch!
Somehow I overlooked this, so in my case of Generic Audio it is always
mono.
Reviewed-by: Ruslan Bilovol <ruslan.bilovol@...il.com>
> case UAC3_CH_MONO:
> map = SNDRV_CHMAP_MONO;
> break;
> --
> 2.11.0
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Powered by blists - more mailing lists