linux-kernel - Re: [PATCH -next] drm/amdkfd: Make function kfd_dev_is_large

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf13NW33eX4T9hYyLJ1Q8Yk+1hdmyfkDTaD2AY=05Ce6VaA@mail.gmail.com>
Date:   Tue, 24 Apr 2018 12:13:35 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Felix Kuehling <felix.kuehling@....com>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static

On Mon, Apr 2, 2018 at 9:03 PM, Felix Kuehling <felix.kuehling@....com> wrote:
> This patch is Reviewed-by: Felix Kuehling <Felix.Kuehling@....com>
>
>
> On 2018-03-29 10:25 PM, Wei Yongjun wrote:
>> Fixes the following sparse warning:
>>
>> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1150:6: warning:
>>  symbol 'kfd_dev_is_large_bar' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
>> ---
>>  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> index cd679cf..fb5d997 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> @@ -1147,7 +1147,7 @@ static int kfd_ioctl_acquire_vm(struct file *filep, struct kfd_process *p,
>>       return ret;
>>  }
>>
>> -bool kfd_dev_is_large_bar(struct kfd_dev *dev)
>> +static bool kfd_dev_is_large_bar(struct kfd_dev *dev)
>>  {
>>       struct kfd_local_mem_info mem_info;
>>
>
Thanks, already applied the fix from the kbuild robot.
Oded