linux-kernel - Re: [PATCH] amdkfd: always select MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf10WSwMUXyvK3-W4qFXak94nrvCQbdJSA4A80yGHpTmzBw@mail.gmail.com>
Date:   Tue, 24 Apr 2018 12:53:21 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Felix Kuehling <felix.kuehling@....com>
Cc:     Anders Roxell <anders.roxell@...aro.org>,
        Christian König <christian.koenig@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Alex Deucher <alexander.deucher@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] amdkfd: always select MMU_NOTIFIER

Thanks, but I took Randy's patch as it was earlier in my email queue.

Oded

On Thu, Apr 19, 2018 at 8:47 PM, Felix Kuehling <felix.kuehling@....com> wrote:
> On 2018-04-19 06:56 AM, Anders Roxell wrote:
>> On 28 March 2018 at 18:04, Christian König <christian.koenig@....com> wrote:
>>> Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
>>>> Building amdkfd without MMU notifiers is broken:
>>>>
>>>> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
>>>> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier'
>>>> has incomplete type
>>>>
>>>> This adds the missing 'select MMU_NOTIFIER' line to make it build
>>>> cleanly all the time.
>>>>
>>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>>
>>> Acked-by: Christian König <christian.koenig@....com>, but I would wait on
>>> what Felix says to that.
>> Tested-by: Anders Roxell <anders.roxell@...aro.org>
>>
>> Randy sent the same patch [1] and its still required.
>>
>> Cheers,
>> Anders
>> [1] https://patchwork.kernel.org/patch/10340885/
> Yes, looks good. I think this probably broke when we relaxed the
> dependency on iommuv2.
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@....com>
>
> Regards,
>   Felix
>
>
>>
>>>
>>>> ---
>>>>   drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> b/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> index ed2f06c9f346..5a26acb90e19 100644
>>>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> @@ -4,6 +4,7 @@
>>>>     config HSA_AMD
>>>>         tristate "HSA kernel driver for AMD GPU devices"
>>>> +       select MMU_NOTIFIER
>>>>         depends on DRM_AMDGPU && X86_64
>>>>         imply AMD_IOMMU_V2
>>>>         help
>>>
>