linux-kernel - Re: [PATCH 2/2] ARM64: dts: allwinner: Add dts file for Libre Computer Board ALL-H3-CC H5 ver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Apr 2018 12:01:48 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Maxime Ripard <maxime.ripard@...tlin.com>
Cc:     wens@...e.org, clabbe@...libre.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM64: dts: allwinner: Add dts file for Libre
 Computer Board ALL-H3-CC H5 ver.

On 24/04/2018 11:59, Maxime Ripard wrote:
> Hi,
> 
> On Tue, Apr 24, 2018 at 11:19:36AM +0200, Neil Armstrong wrote:
>> The Libre Computer Board ALL-H3-CC from Libre Technology is a Raspberry
>> Pi B+ form factor single board computer based on the Allwinner H2+, H3, or H5
>> SoCs with the same PCB.
>> The board has 1GB DDR3 SDRAM, provided by 4 2Gb chips. The mounting holes
>> and connectors are in the exact same position as on the Raspberry Pi B+.
>>
>> This patch enables the H5 variant using the H3 board definition moved to
>> a common dtsi in an earlier patch. The dts simply include the common dtsi
>> and declares the correct compatible and model of the H5 variant.
>>
>> Suggested-by: Corentin Labbe <clabbe@...libre.com>
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> 
> prefix should be "arm64: dts: allwinner"

Bad habit, will resend with arm64.

> 
> You had this issue with the first patch as well, your commit log
> should be wrapped, checkpatch complains at the moment.

Same.

> 
> Maxime
> 

Thanks,
Neil



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)